From 8c3015e5df2c775a6124aa9c86dd6dd9c33dff5d Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Sun, 14 May 2023 09:52:42 -0600
Subject: [PATCH] update linux snap (#1110)

* switch snap from devmode to strict.

* date first in version string

* update snap: strict, no gui, layout
---
 .github/workflows/ubuntu.yml |  2 +-
 snap/snapcraft.yaml          | 37 ++++++++++++++++++------------------
 2 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
index 247cb9c80..e5754277b 100644
--- a/.github/workflows/ubuntu.yml
+++ b/.github/workflows/ubuntu.yml
@@ -95,7 +95,7 @@ jobs:
     # Make sure the snap is installable
     - name: Test
       run: |
-        sudo snap install --devmode --dangerous ${{ steps.build-snap.outputs.snap }}
+        sudo snap install --dangerous ${{ steps.build-snap.outputs.snap }}
         export GBTEMP=$(pwd)/gbtemp
         mkdir -p "$GBTEMP"
         /snap/bin/gpsbabel -D3 || true
diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index 1db316d0f..cd88c786c 100755
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -12,11 +12,25 @@ source-code: https://github.com/GPSBabel/gpsbabel.git
 website: https://www.gpsbabel.org
 
 grade: devel # must be 'stable' to release into candidate/stable channels
-confinement: devmode # use 'strict' once you have the right plugs and slots
+confinement: strict # use 'strict' once you have the right plugs and slots
 
 apps:
   gpsbabel:
-    command: /usr/bin/gpsbabel
+    plugs:
+      - home
+      - raw-usb
+      - removable-media
+      - serial-port
+    command: usr/bin/gpsbabel
+
+# remap the ubuntu qt6 install directories to the snap.
+layout:
+  /usr/share/qt6:
+    symlink: $SNAP/usr/share/qt6
+  /usr/lib/qt6:
+    symlink: $SNAP/usr/lib/qt6
+  /usr/lib/x86_64-linux-gnu/qt6:
+    symlink: $SNAP/usr/lib/x86_64-linux-gnu/qt6
 
 adopt-info: gpsbabel
 parts:
@@ -33,11 +47,13 @@ parts:
       craftctl default
       # add install command to CMakeLists.txt
       echo "install(TARGETS gpsbabel CONFIGURATIONS Release RUNTIME DESTINATION /usr/bin)" >> CMakeLists.txt
+      # no gui
+      sed -i -e's/add_subdirectory(gui)/#add_subdirectory(gui)/' CMakeLists.txt
       # jam repo sha into GITHUB_SHA
       sed -i -e"/GB.SHA/i set(ENV{GITHUB_SHA} \"$(git log -1 --format=%h)\")" gbversion.cmake
       # set snap version
       # ensure version has at most 32 characters
-      craftctl set version=$(git log -1 --format='LinuxInstaller-%h-%ad' --date=format:%Y%m%d)
+      craftctl set version=$(git log -1 --format='LinuxInstaller-%ad-%h' --date=format:%Y%m%d)
 
     build-packages:
       - git
@@ -51,21 +67,6 @@ parts:
       - libudev-dev
       - qt6-base-dev
       - libqt6core5compat6-dev
-      - libqt6opengl6-dev
-      - libqt6serialport6-dev
-      - libqt6webenginecore6-bin
-      - libgl-dev
-      - libopengl-dev
-      - libvulkan-dev
-      - libx11-xcb-dev
-      - libxkbcommon-dev
-      - qt6-l10n-tools
-      - qt6-tools-dev
-      - qt6-tools-dev-tools
-      - qt6-translations-l10n
-      - qt6-webengine-dev
-      - qt6-webengine-dev-tools
-      - qt6-wayland
     stage-packages:
       - zlib1g
       - libshp2
-- 
2.30.2